Skip to content

python-matplotlib: optionally install tests#12218

Closed
rycee wants to merge 1 commit intoNixOS:masterfrom
rycee:matplotlib/optional-test-install
Closed

python-matplotlib: optionally install tests#12218
rycee wants to merge 1 commit intoNixOS:masterfrom
rycee:matplotlib/optional-test-install

Conversation

@rycee
Copy link
Member

@rycee rycee commented Jan 7, 2016

The tests typically are not needed and avoiding their installation by default saves 55–60MB.

The tests typically are not needed and avoiding their installation by
default saves 55-60MB.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @FRidh, @domenkozar and @datakurre to be potential reviewers

@FRidh
Copy link
Member

FRidh commented Jan 8, 2016

55-60 MB is a lot, however, I don't think it is a good idea to put this in the specific function of Matplotlib. Instead, I think it would be better if we do this in buildPythonPackage, either with an option like you propose, where you can pass false or a list of paths, or have a specific phase for this.

@FRidh
Copy link
Member

FRidh commented Jan 8, 2016

Also, by removing the tests in the patch phase the software cannot be tested. I don't think that is what we want, though I am not entirely sure how it is done with packages in setup.cfg.

@rycee
Copy link
Member Author

rycee commented Jan 8, 2016

Unfortunately I won't have the time and energy to do a general solution to this. Honestly I don't know enough about Python or Python packaging to even tell whether I could make a general solution :-)

In any case, the proposed patch does not prevent the tests from being run when building the package. It only prevents the test suite (and in particular the large baseline image set) from being installed into the Nix store. Another solution might be the one I see Debian takes, they seem to install the test suite but omit the images.

@FRidh FRidh added 0.kind: enhancement Add something new or improve an existing system. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 14, 2016
@FRidh
Copy link
Member

FRidh commented Apr 22, 2016

Closing in favor of a more generic solution.

@FRidh FRidh closed this Apr 22, 2016
@rycee rycee deleted the matplotlib/optional-test-install branch June 26, 2016 16:54
FRidh added a commit to FRidh/nixpkgs that referenced this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants