Skip to content

Revert 99132 recursive type deprecation#121816

Merged
infinisil merged 2 commits intoNixOS:masterfrom
hercules-ci:revert-99132-recursive-type-deprecation
May 5, 2021
Merged

Revert 99132 recursive type deprecation#121816
infinisil merged 2 commits intoNixOS:masterfrom
hercules-ci:revert-99132-recursive-type-deprecation

Conversation

@roberth
Copy link
Member

@roberth roberth commented May 5, 2021

Motivation for this change

Address #99132 (comment)

Merge after ofborg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth requested review from edolstra, infinisil and nbp as code owners May 5, 2021 16:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 5, 2021
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's go with this for now, seems to cause too many problems

@infinisil
Copy link
Member

infinisil commented May 5, 2021

Also nix-community/home-manager#1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants