Skip to content

Remove 7f#12151

Closed
matthewbauer wants to merge 1 commit intoNixOS:masterfrom
matthewbauer:patch-1
Closed

Remove 7f#12151
matthewbauer wants to merge 1 commit intoNixOS:masterfrom
matthewbauer:patch-1

Conversation

@matthewbauer
Copy link
Member

The 7f package caused nodejs to upgrade to nodejs-7f (the version checker thinks it is a version of nodejs).

Caused nodejs to upgrade to nodejs-7f (the version checker thinks it is a version of nodejs.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @flosse, @offlinehacker and @svanderburg to be potential reviewers

@jgillich
Copy link
Member

jgillich commented Jan 5, 2016

Wait, what? The package name should be 7f-${version}, I don't see how Nix could possibly confuse it with nodejs.

@copumpkin
Copy link
Member

The node builder might be sticking "nodejs-" in front of the name, which then causes the shitty nix-env version-parsing logic (shitty because we need to do it, not because it's doing a bad job) to interpret 7f as a version of nodejs instead of a package. The logic apparently looks for the first hyphen followed by a numeric character.

@vcunat
Copy link
Member

vcunat commented Jan 5, 2016

IMO starting package names with numbers is a bad practice, and "7f" will confuse even some human readers. (What is node-7f-1.1.3?)

There's also an option to somehow make 7f lowPrio so it won't be considered.

@vcunat
Copy link
Member

vcunat commented Jan 5, 2016

/cc the one who introduced it: @flosse.

@flosse
Copy link
Contributor

flosse commented Jan 5, 2016

As already mentioned we can really remove this package!

@vcunat vcunat closed this in 45ade79 Jan 5, 2016
@vcunat
Copy link
Member

vcunat commented Jan 5, 2016

This PR wasn't enough to remove it. I pushed one that does (hopefully correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants