Skip to content

timeline: init at 2.4.0#120453

Merged
jonringer merged 3 commits intoNixOS:masterfrom
davidak:timeline
May 9, 2021
Merged

timeline: init at 2.4.0#120453
jonringer merged 3 commits intoNixOS:masterfrom
davidak:timeline

Conversation

@davidak
Copy link
Member

@davidak davidak commented Apr 23, 2021 •
edited
Loading

Motivation for this change

i want to use the package

Screenshot from 2021-04-23 23-09-44

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 23, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2021
@davidak davidak force-pushed the timeline branch 2 times, most recently from 9631243 to c9b8b4b Compare April 23, 2021 21:16
@davidak davidak marked this pull request as ready for review April 23, 2021 21:18
@davidak davidak requested review from FRidh and jonringer as code owners April 23, 2021 21:18
@davidak davidak force-pushed the timeline branch 3 times, most recently from 56ae298 to 6dacc71 Compare April 23, 2021 22:00
@SuperSandro2000 SuperSandro2000 changed the title Add Timeline timeline: init at 2.4.0 Apr 23, 2021
SuperSandro2000
SuperSandro2000 reviewed Apr 23, 2021
View reviewed changes
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 23, 2021 •
edited
Loading

Result of nixpkgs-review pr 120453 at 6dacc710 run on x86_64-linux 1

3 packages failed to build:
2 packages built successfully:
  • python38Packages.humblewx
  • python39Packages.humblewx
2 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/humblewx/default.nix:34:0:

       |
34 |     description = "Library that simplifies creating user interfaces with wxPython";
   | ^
  • warning: python-inconsistent-interpreters

    Between buildPythonPackage and propagatedBuildInputs, this derivation seems
    to be simultaneously trying to use packages from multiple different Python package sets.
    Mixing package sets like this is not supported.

    Detected Python packages:

    • python3-3.8.8
    • python3-3.9.2

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 120453 at 6dacc710 run on aarch64-linux 1

3 packages failed to build:
2 packages built successfully:
  • python38Packages.humblewx
  • python39Packages.humblewx
2 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/humblewx/default.nix:34:0:

       |
34 |     description = "Library that simplifies creating user interfaces with wxPython";
   | ^
  • warning: python-inconsistent-interpreters

    Between buildPythonPackage and propagatedBuildInputs, this derivation seems
    to be simultaneously trying to use packages from multiple different Python package sets.
    Mixing package sets like this is not supported.

    Detected Python packages:

    • python3-3.8.8
    • python3-3.9.2

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 120453 at 88535b69 run on aarch64-linux 1

5 packages built successfully:
  • python38Packages.humblewx
  • python38Packages.pysvg-py3
  • python39Packages.humblewx
  • python39Packages.pysvg-py3
  • timeline

@davidak
Copy link
Member Author

davidak commented Apr 24, 2021 •
edited
Loading

Result of nixpkgs-review pr 120453 run on x86_64-linux 1

5 packages built:
  • python38Packages.humblewx
  • python38Packages.pysvg-py3
  • python39Packages.humblewx
  • python39Packages.pysvg-py3
  • timeline

Fails to start:

[nix-shell:~/.cache/nixpkgs-review/pr-120453-2]$ timeline
Traceback (most recent call last):
  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/bin/.timeline-wrapped", line 35, in <module>
    from timelinelib.meta.about import APPLICATION_NAME
  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/lib/python3.8/site-packages/timelinelib/meta/about.py", line 22, in <module>
    import wx.adv
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/__init__.py", line 17, in <module>
    from wx.core import *
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/core.py", line 12, in <module>
    from ._core import *
ModuleNotFoundError: No module named 'wx._core'

This only happens in this nix-shell, not when installed with nix-env -f . -iA timeline. Maybe because nixpkgs-review builds all versions.

@davidak
Copy link
Member Author

davidak commented Apr 24, 2021

@rmcgibbo would you be so kind and retest on ARM?

@davidak
Copy link
Member Author

davidak commented Apr 24, 2021 •
edited
Loading

Result of nixpkgs-review pr 120453 run on x86_64-linux 1

1 package built:
  • timeline

It works when i test just the one package.

Use this to test the program:

nix run nixpkgs-review -c nixpkgs-review pr 120453 -p timeline

This was referenced Apr 24, 2021
Open
Merged
@davidak
humblewx: init at 0.2.2
5b82488 
needed for timeline package
@davidak
pysvg-py3: init at 0.2.2-post3
991c9ca 
needed for timeline package
@davidak
Copy link
Member Author

davidak commented May 1, 2021

I have rebased and fixed the merge conflict.

Also used it the last days and tested every feature. It works perfectly.

Can we get it merged?

@jonringer
Copy link
Contributor

jonringer commented May 1, 2021 •
edited
Loading

the nix-shell failure is because the PYTHONPATH is including packages from both interpreters:

  File "/nix/store/8h7dh80qxvg0bsbp1rxb9k3854ngxdk0-timeline-2.4.0/lib/python3.8/site-packages/timelinelib/meta/about.py", line 22, in <module>
    import wx.adv
  File "/nix/store/ii08mxqpcxlywbpirqjk4pnydi9l3b5d-python3.9-wxPython-4.0.7.post2/lib/python3.9/site-packages/wx/__init__.py", line 17, in <module>
    from wx.core import *

This shouldn't be the case in practice, as buildPythonApplication wouldn't export anything on PYTHONPATH.

jonringer
jonringer reviewed May 1, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@davidak
Copy link
Member Author

davidak commented May 9, 2021

@jonringer can you review again?

jonringer
jonringer approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/120453

5 packages built:
python38Packages.humblewx python38Packages.pysvg-py3 python39Packages.humblewx python39Packages.pysvg-py3 timeline

@davidak davidak deleted the timeline branch May 9, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

+1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidak @r-rmcgibbo @jonringer @SuperSandro2000