Skip to content

nodejs-16_x: init at 16.0.0#120008

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
marsam:init-nodejs-16_x
Apr 21, 2021
Merged

nodejs-16_x: init at 16.0.0#120008
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
marsam:init-nodejs-16_x

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Apr 20, 2021

Motivation for this change

https://github.com/nodejs/node/releases/tag/v16.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2021
@SuperSandro2000 SuperSandro2000 merged commit 494b319 into NixOS:master Apr 21, 2021
@marsam marsam deleted the init-nodejs-16_x branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants