Skip to content

Comments

coreutils: disable tests which fail in sandbox#116241

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:coreutils-sandbox
Jun 1, 2021
Merged

coreutils: disable tests which fail in sandbox#116241
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:coreutils-sandbox

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 13, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Mar 13, 2021
@ofborg ofborg bot requested a review from edolstra March 13, 2021 22:17
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 13, 2021
@veprbl
Copy link
Member

veprbl commented Mar 13, 2021

Is coreutils broken currently? I don't see a failing build on Hydra.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Mar 14, 2021

I don't think this is broken for hydra but when building it on my machine it is broken. I needed to rebuild the full stdenv for testing futile coreutils stdenv and this prevented me from doing that.

@FRidh FRidh added this to the 21.05 milestone Mar 20, 2021
@veprbl
Copy link
Member

veprbl commented Mar 22, 2021

"futile"? future? Is this for a version bump? I still don't understand, sorry.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Apr 3, 2021

"futile"? future? Is this for a version bump? I still don't understand, sorry.

I meant to write uutils coreutils stdenv which I was trying at the time.

@SuperSandro2000 SuperSandro2000 mentioned this pull request May 30, 2021
Merged
27 tasks
@SuperSandro2000 SuperSandro2000 merged commit 1f831f0 into NixOS:staging Jun 1, 2021
@SuperSandro2000 SuperSandro2000 deleted the coreutils-sandbox branch June 1, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

No open projects
Staging
Archived in project

Milestone

21.05

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @veprbl @FRidh