Skip to content

Comments

gnome-tour: fix build#114673

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:fix-rust-plus-gnome
Feb 28, 2021
Merged

gnome-tour: fix build#114673
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:fix-rust-plus-gnome

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 28, 2021

Motivation for this change

Fixes #114659

There might be other packages broken, so I'm going to see if the gnome test builds locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 28, 2021
vcunat
vcunat reviewed Feb 28, 2021
View reviewed changes
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Feb 28, 2021

gnome3 test succeeds

@ofborg ofborg bot requested review from dasj19, hedning and jtojnar February 28, 2021 15:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 28, 2021
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Feb 28, 2021

not waiting for the builds in CI 😁

@worldofpeace worldofpeace merged commit 7a934e4 into NixOS:master Feb 28, 2021
@worldofpeace worldofpeace deleted the fix-rust-plus-gnome branch February 28, 2021 16:01
@collares collares mentioned this pull request Mar 1, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat left review comments

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gnome-tour: build fails to find generated resources

2 participants

@worldofpeace @vcunat