ocamlPackages.ocamlmod: disable tests if ounit is not available#113771
Merged
vbgl merged 1 commit intoNixOS:masterfrom Feb 21, 2021
Merged
ocamlPackages.ocamlmod: disable tests if ounit is not available#113771vbgl merged 1 commit intoNixOS:masterfrom
vbgl merged 1 commit intoNixOS:masterfrom
Conversation
When we redid ounit and ounit2, the minimumOCamlVersion was also pushed to OCaml 4.04. ocamlmod builds on earlier versions as well, but doesn't evaluate if we pull in ounit. Therefore we conditionally disable tests for OCaml < 4.04 which means for example oasis is available for those versions again as well.
ofborg
bot
added
10.rebuild-darwin: 1-10
sternenseemann
added
the
6.topic: ocaml
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Jul 24, 2021
These packages have been failing to evaluate for some time now for two reasons: * ocamlmod doesn't evaluate for OCaml < 4.04 which is fixed in NixOS#113771 * We have no ppx_core version for OCaml < 4.03 which is a fundamental issue. Since this situation has been going on for some time now, I don't really see the need to figure out how to fix these legacy versions of some janestreet packages. There is also additional motivation: * These packages reference the janeStreet set directly which I'd like to deprecate, as it spells trouble for the overriding possibilities introduced in NixOS#113696. * These packages are patched in awkwardly into the janeStreet set without forming one themselves. By removing them we can move closer to having all janestreet packages managed uniformly in their own janestreet sets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we redid ounit and ounit2, the minimumOCamlVersion was also pushed
to OCaml 4.04. ocamlmod builds on earlier versions as well, but doesn't
evaluate if we pull in ounit.
Therefore we conditionally disable tests for OCaml < 4.04 which means
for example oasis is available for those versions again as well.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)