go_bootstrap: remove top-level attribute#113113
Merged
kalbasit merged 1 commit intoNixOS:masterfrom Feb 15, 2021
zowoq:goboot
Merged
go_bootstrap: remove top-level attribute#113113kalbasit merged 1 commit intoNixOS:masterfrom zowoq:goboot
kalbasit merged 1 commit intoNixOS:masterfrom
zowoq:goboot
Conversation
this package should only be used internally for go_*
ofborg
bot
added
6.topic: golang
Contributor
Author
|
@ofborg build go_1_14 go_1_15 podman |
bobrik
reviewed
Feb 15, 2021
| srcOnly { | ||
| name = "go-1.8-linux-arm64-bootstrap"; | ||
| src = fetchurl { | ||
| url = "https://cache.xor.us/go-1.8-linux-arm64-bootstrap.tar.xz"; |
Contributor
There was a problem hiding this comment.
This file is still not accessible if not for cache.nixos.org:
* SSL: no alternative certificate subject name matches target host name 'cache.xor.us'
It also doesn't feel very trustworthy.
How do you feel about bootstrapping from golang.org binary packages repackaged to look like bootstrap? I have the following for aarch64-darwin locally:
(srcOnly {
name = "go-1.16-rc1-darwin-arm64-bootstrap";
src = fetchurl {
url = "https://golang.org/dl/go1.16rc1.darwin-arm64.tar.gz";
sha256 = "1p9l9qrh5x06jw19bnyfz8hfq6fisxzhc39cq6gwg4xcvn7gxq7m";
};
}).overrideAttrs (_: rec {
installPhase = ''
mkdir -p $out/share/go $out/bin
mv bin/* $out/bin
cp -r . $out/share/go
'';
})Same idea would apply to aarch64-linux here, or to any arch that cannot be bootstrapped from go1.4.
Member
There was a problem hiding this comment.
This was partially discussed in #110794, IMO please open a new issue so we can discuss it. Personally, I think it would be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #110794
Closes #73643
Closes #88315
Closes #93989
Closes #96786
Closes #99778
Closes #106194
Closes #106195
Closes #109174
Closes #109175
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @NixOS/golang