go_1_14, go_1_15, go_2-dev: only override stdenv if it is gcc#112248
Merged
kalbasit merged 1 commit intoNixOS:masterfrom Feb 15, 2021
Merged
go_1_14, go_1_15, go_2-dev: only override stdenv if it is gcc#112248kalbasit merged 1 commit intoNixOS:masterfrom
kalbasit merged 1 commit intoNixOS:masterfrom
Conversation
This doesn't do anything for existing packages, but it helps NixOS#105026, since `aarch64-darwin` doesn't have a working gcc today.
ofborg
bot
added
10.rebuild-darwin: 0
dotlambda
changed the title
zowoq
approved these changes
Feb 13, 2021
Contributor
zowoq
left a comment
zowoq
left a comment
There was a problem hiding this comment.
Looks fine.
cc @NixOS/golang
kalbasit
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This doesn't do anything for existing packages, but it helps #105026,since
aarch64-darwindoesn't have a working gcc today.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)