Skip to content

Comments

evilpixie: 0.2 -> 0.2.1#108215

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
fgaz:evilpixie/0.2.1
Jan 3, 2021
Merged

evilpixie: 0.2 -> 0.2.1#108215
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
fgaz:evilpixie/0.2.1

Conversation

@fgaz
Copy link
Member

@fgaz fgaz commented Jan 2, 2021 •
edited
Loading

Motivation for this change

#104474
bcampbell/evilpixie#14
https://github.com/bcampbell/evilpixie/releases/tag/v0.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 2, 2021
@fgaz fgaz mentioned this pull request Jan 2, 2021
Merged
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 2, 2021 •
edited
Loading

Result of nixpkgs-review pr 108215 run on x86_64-linux 1

1 package built:
  • evilpixie

Working fine and code LGTM

@nixos-discourse
Copy link

nixos-discourse commented Jan 2, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/321

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 2, 2021 •
edited
Loading

Result of nixpkgs-review pr 108215 1

1 package built:
  • evilpixie

Tested and seems to work (I can show my horrible draw skills on it).

@SuperSandro2000 SuperSandro2000 merged commit 0960eff into NixOS:master Jan 3, 2021
@fgaz fgaz deleted the evilpixie/0.2.1 branch January 3, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

+1 more reviewer

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fgaz @WolfangAukang @nixos-discourse @thiagokokada @SuperSandro2000