Skip to content

pythonPackages.python-prctl: disabled tests causing build failure#106875

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
kira-bruneau:pythonPackages.python-prctl
Mar 21, 2021
Merged

pythonPackages.python-prctl: disabled tests causing build failure#106875
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
kira-bruneau:pythonPackages.python-prctl

Conversation

@kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Dec 14, 2020 •
edited
Loading

Motivation for this change

Fixes #106871

Now disables tests using pytestCheckHook + disabledTests instead of patch file.

Disables:

  • test_speculation_ctrl
  • test_mpx

Enables:

  • test_mce_kill
  • test_proctitle
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    No binary files, package is library
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 14, 2020
@kira-bruneau kira-bruneau force-pushed the pythonPackages.python-prctl branch from 1a59269 to 47edd37 Compare December 14, 2020 04:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 14, 2020
catern
catern reviewed Dec 14, 2020
View reviewed changes
@catern
Copy link
Contributor

catern commented Dec 14, 2020

Looks good besides the comment nitpick.

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Dec 14, 2020

@catern Oh sorry about that, I'll update that. Thank you 😄

@kira-bruneau kira-bruneau force-pushed the pythonPackages.python-prctl branch from 47edd37 to cfefa5c Compare December 14, 2020 05:24
@catern catern mentioned this pull request Dec 14, 2020
Open
@kira-bruneau kira-bruneau changed the title pythonPackages.python-prctl: disable test_speculation_ctrl pythonPackages.python-prctl: disable test_speculation_ctrl to fix build Dec 19, 2020
@kira-bruneau kira-bruneau mentioned this pull request Dec 28, 2020
Closed
29 tasks
@rmcgibbo
Copy link
Contributor

rmcgibbo commented Dec 31, 2020

Result of nixpkgs-review pr 106875 run on x86_64-linux 1

3 packages built:
  • python37Packages.python-prctl
  • python38Packages.python-prctl
  • python39Packages.python-prctl

@kira-bruneau kira-bruneau force-pushed the pythonPackages.python-prctl branch from cfefa5c to 0f75b2b Compare January 4, 2021 05:22
@kira-bruneau
pythonPackages.python-prctl: disabled tests causing build failure
d29570f 
Now disables tests using pytestCheckHook + disabledTests instead of
patch file.

Disables:
- test_speculation_ctrl
- test_mpx

Enables:
- test_mce_kill
- test_proctitle
@kira-bruneau kira-bruneau force-pushed the pythonPackages.python-prctl branch from 0f75b2b to d29570f Compare January 4, 2021 05:23
@kira-bruneau kira-bruneau changed the title pythonPackages.python-prctl: disable test_speculation_ctrl to fix build pythonPackages.python-prctl: disabled tests causing build failure Jan 4, 2021
@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Jan 4, 2021

@catern test_mpx also started failing since #107783, so I added it as a disabled test.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 21, 2021

@ofborg eval

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 21, 2021

Those tests no longer fail in 1.8.1.

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Mar 21, 2021 •
edited
Loading

@SuperSandro2000 This commit was based on failures found in version 1.8.1. I just tried the latest version of master, and they're still failing for me:

======================================================================
ERROR: test_mpx (test_prctl.PrctlTest)
Test MPX enabling/disabling
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/python-prctl-1.8.1/test_prctl.py", line 207, in test_mpx
    self.assertEqual(prctl.mpx_enable_management(), None)
  File "/build/python-prctl-1.8.1/build/lib.linux-x86_64-3.8/prctl.py", line 16, in call_prctl
    return _prctl.prctl(option)
OSError: [Errno 22] Invalid argument

======================================================================
ERROR: test_speculation_ctrl (test_prctl.PrctlTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/python-prctl-1.8.1/test_prctl.py", line 335, in test_speculation_ctrl
    prctl.set_speculation_ctrl(prctl.SPEC_STORE_BYPASS, prctl.SPEC_ENABLE)
  File "/build/python-prctl-1.8.1/build/lib.linux-x86_64-3.8/prctl.py", line 19, in call_prctl
    return _prctl.prctl(option, arg, arg2)
PermissionError: [Errno 1] Operation not permitted

----------------------------------------------------------------------
Ran 33 tests in 0.005s

FAILED (errors=2, skipped=4)
Test failed: <unittest.runner.TextTestResult run=33 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=33 errors=2 failures=0>

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Mar 21, 2021

I'm reopening this because this is still broken on hydra, and has been broken since 2020-12-06: https://hydra.nixos.org/build/139366147.

@kira-bruneau kira-bruneau reopened this Mar 21, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 21, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106875 run on x86_64-linux 1

3 packages built:
  • python37Packages.python-prctl
  • python38Packages.python-prctl
  • python39Packages.python-prctl

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details python37Packages.python-prctl:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/python-prctl/default.nix:39:5:

   |
39 |     license = lib.licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@SuperSandro2000 SuperSandro2000 merged commit 6be0d00 into NixOS:master Mar 21, 2021
@kira-bruneau kira-bruneau deleted the pythonPackages.python-prctl branch December 6, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

2 more reviewers

@rmcgibbo rmcgibbo rmcgibbo approved these changes

@catern catern catern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pythonPackages.python-prctl fails to build

4 participants

@kira-bruneau @catern @rmcgibbo @SuperSandro2000