Skip to content

mesa: find prefixed nm when cross compiling#106804

Merged
vcunat merged 1 commit intoNixOS:masterfrom
Atemu:fix/mesa-cross
Dec 13, 2020
Merged

mesa: find prefixed nm when cross compiling#106804
vcunat merged 1 commit intoNixOS:masterfrom
Atemu:fix/mesa-cross

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Dec 13, 2020

Motivation for this change

#106759

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu mentioned this pull request Dec 13, 2020
Closed
9 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 13, 2020
@Atemu Atemu added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 13, 2020
@Atemu Atemu mentioned this pull request Dec 13, 2020
Closed
vcunat
vcunat approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the build. (not musl, as there's a different problem) LLVM isn't found, but let's not block this fix because of that.

EDIT: musl builds for me after 37dfd61.

@vcunat vcunat merged commit e955c43 into NixOS:master Dec 13, 2020
@Atemu Atemu deleted the fix/mesa-cross branch December 13, 2020 10:42
@Ericson2314
Copy link
Member

Ericson2314 commented Dec 13, 2020

Thanks for fixing, @Atemu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Atemu @Ericson2314 @vcunat