Skip to content

Comments

goldendict: 2020-05-27 -> 2020-12-09#106774

Merged
gebner merged 1 commit intoNixOS:masterfrom
gebner:goldendict-qt515
Dec 12, 2020
Merged

goldendict: 2020-05-27 -> 2020-12-09#106774
gebner merged 1 commit intoNixOS:masterfrom
gebner:goldendict-qt515

Conversation

@gebner
Copy link
Member

@gebner gebner commented Dec 12, 2020

Motivation for this change

Update git revision and use qt 5.15. See #104474.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner mentioned this pull request Dec 12, 2020
Merged
@ofborg ofborg bot requested review from astsmtl and sikmir December 12, 2020 18:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 12, 2020
@gebner gebner merged commit 6e7cc1a into NixOS:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astsmtl astsmtl Awaiting requested review from astsmtl

@sikmir sikmir Awaiting requested review from sikmir

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gebner