Skip to content

cifs-utils: don't check for AC_FUNC_MALLOC when cross compiling#106761

Merged
matthewbauer merged 1 commit intoNixOS:masterfrom
Atemu:fix/cifs-utils-cross
Dec 14, 2020
Merged

cifs-utils: don't check for AC_FUNC_MALLOC when cross compiling#106761
matthewbauer merged 1 commit intoNixOS:masterfrom
Atemu:fix/cifs-utils-cross

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Dec 12, 2020

Motivation for this change

#106759

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 12, 2020
Produces "undefined reference to "rpl_malloc"" and fails the build

Apparently it's a runtime check (llnl/ior#4)
@Atemu Atemu force-pushed the fix/cifs-utils-cross branch from 4257203 to 46224b1 Compare December 13, 2020 06:59
@Atemu Atemu requested a review from matthewbauer December 13, 2020 07:00
@Atemu Atemu added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 13, 2020
@matthewbauer matthewbauer merged commit 079535f into NixOS:master Dec 14, 2020
@Atemu Atemu deleted the fix/cifs-utils-cross branch November 26, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants