Skip to content

libmodplug: Fix build on darwin#106430

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
avdv:fix-libmodplug-darwin
Dec 10, 2020
Merged

libmodplug: Fix build on darwin#106430
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
avdv:fix-libmodplug-darwin

Conversation

@avdv
Copy link
Member

@avdv avdv commented Dec 9, 2020

Motivation for this change

The libmodplug builds on darwin are broken for quite some time. See #105573

Removing the -mmacosx-min-version clang flag makes it work again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@avdv
libmodplug: Fix build on darwin
144e9c7 
* removing the `-mmacosx-version-min` flag makes the build work again
* also fix the path to the `file` command in the configure script
  to fix the warning

```
./configure: line 7754: /usr/bin/file: No such file or directory
```
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 9, 2020
@ofborg ofborg bot requested a review from 7c6f434c December 9, 2020 09:25
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 9, 2020
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 9, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 9, 2020

libmodplug now builds on darwin.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 10, 2020

and also on linux.

@SuperSandro2000 SuperSandro2000 merged commit 6577837 into NixOS:master Dec 10, 2020
@avdv avdv deleted the fix-libmodplug-darwin branch December 10, 2020 05:35
@avdv avdv mentioned this pull request Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avdv @SuperSandro2000