Skip to content

perlPackages.Appcpm: 0.994 -> 0.995#105537

Merged
stigtsp merged 1 commit intoNixOS:masterfrom
zakame:updates/perl-App-cpm-0.995
Dec 1, 2020
Merged

perlPackages.Appcpm: 0.994 -> 0.995#105537
stigtsp merged 1 commit intoNixOS:masterfrom
zakame:updates/perl-App-cpm-0.995

Conversation

@zakame
Copy link
Member

@zakame zakame commented Dec 1, 2020 •
edited
Loading

Motivation for this change

https://metacpan.org/release/SKAJI/App-cpm-0.995

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner December 1, 2020 03:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2020
stigtsp
stigtsp approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105537 run on x86_64-linux 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

@stigtsp stigtsp merged commit c85ce0c into NixOS:master Dec 1, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 1, 2020

Result of nixpkgs-review pr 105537 run on x86_64-darwin 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

@zakame
Copy link
Member Author

zakame commented Dec 2, 2020

Thanks again! 🎉

@zakame zakame deleted the updates/perl-App-cpm-0.995 branch December 2, 2020 05:34
@avdv avdv mentioned this pull request Dec 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zakame @SuperSandro2000 @stigtsp