Skip to content

Comments

heaptrack: migrate to Qt5.15#104442

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-heaptrack
Nov 28, 2020
Merged

heaptrack: migrate to Qt5.15#104442
doronbehar merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-heaptrack

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 21, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

RaghavSood commented Nov 23, 2020

Result of nixpkgs-review pr 104442 1

1 package built:
  • heaptrack

@doronbehar
Copy link
Contributor

doronbehar commented Nov 28, 2020

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 28, 2020
@doronbehar doronbehar merged commit 7d75a77 into NixOS:master Nov 28, 2020
@gebner gebner mentioned this pull request Dec 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freezeboy @RaghavSood @doronbehar