Skip to content

Fsharp41: get file name without extension type inference patch#103223

Merged
7c6f434c merged 3 commits intoNixOS:masterfrom
moinessim:fsharp41/get-file-name-without-extension-type-inference-patch
Nov 10, 2020
Merged

Fsharp41: get file name without extension type inference patch#103223
7c6f434c merged 3 commits intoNixOS:masterfrom
moinessim:fsharp41/get-file-name-without-extension-type-inference-patch

Conversation

@moinessim
Copy link
Copy Markdown
Contributor

Motivation for this change

I got this error when building fsharp41:
/private/var/folders/.../nix-build-fsharp-4.1.34.drv-0/fsharp-4.1.34/src/scripts/fssrgen.fsx(334,28) : error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point. A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan< char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string (...)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c and thoughtpolice November 9, 2020 18:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 9, 2020
@7c6f434c
Copy link
Copy Markdown
Member

@ofborg build fsharp41

@7c6f434c 7c6f434c merged commit 24c8927 into NixOS:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants