Skip to content

pythonPackages.smugline,pythonPackages.smugpy: remove#102610

Merged
jonringer merged 2 commits intoNixOS:masterfrom
omasanori:smugline/remove
Nov 4, 2020
Merged

pythonPackages.smugline,pythonPackages.smugpy: remove#102610
jonringer merged 2 commits intoNixOS:masterfrom
omasanori:smugline/remove

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Nov 3, 2020

Motivation for this change

Upstream states that smugline is no longer maintained and smugpy was abandoned.

Part of #101964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 3, 2020
@omasanori omasanori changed the title pythonPackages.smugline: remove pythonPackages.smugline,pythonPackages.smugpy: remove Nov 3, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

cc @jtojnar

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102610 1

@omasanori omasanori deleted the smugline/remove branch November 4, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants