Skip to content

haxor-news: use python3, fix build#102391

Merged
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:fix-haxor-news
Nov 3, 2020
Merged

haxor-news: use python3, fix build#102391
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:fix-haxor-news

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2020

Motivation for this change

related: #101964

also fixes build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

cc @matthiasbeyer

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 1, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102391 run on x86_64-darwin 1

1 package built:
  • haxor-news

@erictapen
Copy link
Member

@jonringer Sure this is backport worthy? Builds for me on 20.09 and it doesn't seem to contain any security fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants