Skip to content

pipreqs: use python3#102389

Merged
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:pipreqs-py3
Nov 24, 2020
Merged

pipreqs: use python3#102389
jonringer merged 1 commit intoNixOS:masterfrom
jonringer:pipreqs-py3

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2020 •
edited
Loading

Motivation for this change

related: #101964

although this may lose support to parse python2 code, I think the compromise is worth it for not introducing vulnerabilities to a user's system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from PsyanticY November 1, 2020 21:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 1, 2020
FRidh
FRidh reviewed Nov 1, 2020
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 2, 2020

Result of nixpkgs-review pr 102389 run on x86_64-darwin 1

1 package built:
  • pipreqs

@jonringer
Copy link
Contributor Author

jonringer commented Nov 24, 2020

shows usage

going to merge to move foward with marking cryptography insecure

https://github.com/NixOS/nixpkgs/pull/102389
1 package built:
pipreqs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

1 more reviewer

@FRidh FRidh FRidh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonringer @SuperSandro2000 @FRidh