Skip to content

Comments

kdenlive: fix package#102364

Merged
FRidh merged 3 commits intoNixOS:masterfrom
FRidh:kdenlive
Nov 1, 2020
Merged

kdenlive: fix package#102364
FRidh merged 3 commits intoNixOS:masterfrom
FRidh:kdenlive

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 1, 2020 •
edited
Loading

Motivation for this change

Build and runs fine.

Note you may get an issue running this if your GL build is different.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel as a code owner November 1, 2020 16:56
@FRidh FRidh changed the title kdenlive: fix build kdenlive: fix package Nov 1, 2020
@FRidh FRidh added the 6.topic: qt/kde Object-oriented framework for GUI creation label Nov 1, 2020
@FRidh FRidh mentioned this pull request Nov 1, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 1, 2020
mohe2015
mohe2015 approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, it works.

@FRidh FRidh merged commit c3d017e into NixOS:master Nov 1, 2020
@FRidh FRidh deleted the kdenlive branch November 1, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

1 more reviewer

@mohe2015 mohe2015 mohe2015 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FRidh @mohe2015