nixos/anbox: use mainline drivers when available by mvnetbiz · Pull Request #102341 · NixOS/nixpkgs

mvnetbiz · 2020-11-01T10:48:06Z

Motivation for this change

virtualisation.anbox is broken on Linux 5.x

Things done

updated Anbox package to latest version
marked anbox kernel modules broken for Linux >= 5.7. They do not build because Linux 5.7 unexported kallsyms_lookup_name()
enable CONFIG_ options for the mainline kernel drivers needed
change Anbox NixOS module to use the correct drivers if using Linux 5.x

I have confirmed this working with Linux 4.19, 5.4, 5.7

pkgs/os-specific/linux/anbox/default.nix

mvnetbiz · 2020-11-03T05:28:37Z

I've fixed the build inputs, fixed up some stuff like .desktop file and app menu category, and added a test for the service module.

mvnetbiz · 2020-11-19T07:33:29Z

Rebased and fixed the nixos test to be reliable. Are there any concerns since this changes the kernel?

spinus · 2020-11-28T02:48:31Z

nixos/modules/virtualisation/anbox.nix

don't you have to add Type=fork if you use daemon here?
You are adding it only to avoid the warning or any other reason?

I did add it to avoid the warning but the process doesn't fork anyways, or at least doesn't exit.

spinus · 2020-11-28T02:49:46Z

@mvnetbiz thanks, that looks pretty good.

mvnetbiz · 2020-12-03T02:49:37Z

I don't know what considerations should be taken for adding drivers to the default kernel, or if there is an alternative option.

Atemu

Amazing work!

Working as ~~well~~poorly as upstream allows AFAICT. Tested on linux_zen 5.9. Networking works too.

Atemu · 2020-12-23T08:49:16Z

nixos/modules/virtualisation/anbox.nix

Shouldn't this stay but put behind a conditional for useAnboxModules?

As far as I can tell these rules don't do anything anyways.

I can't recall but they either don't run or anbox works correctly with the default mode anyways.

Atemu · 2020-12-23T08:50:11Z

nixos/tests/anbox.nix

Nixpkgs' adb has a proprietary license, not sure whether we could run this test in hydra.

Will that just cause an evaluation error or any other problems? I am assuming it is still okay to keep the test here.

(Will probably adapt to the new PR)

I think it's time we have a non-SDK package for adb, fastboot and friends.

And there is one!

https://github.com/nmeum/android-tools

This is currently in use by Alpine Linux

https://git.alpinelinux.org/aports/tree/community/android-tools/APKBUILD

bqv · 2021-01-07T02:22:55Z

Ping @mvnetbiz

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from #102341 (cherry picked from commit c2e142d)

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

As noted in NixOS#102341 this is not actually running as a forked process. It only tells the process that it is running "as a daemon, so shut the warning up". See `daemon_` here - https://github.com/anbox/anbox/blob/9de4e87cdd05135e1c71e6eadb68bf82719cebdf/src/anbox/cmds/container_manager.cpp#L38-L79 It is **strictly** used to hide that message. Co-authored-by: Matt Votava <[email protected]>

ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 1, 2020

ofborg bot requested a review from edwtjo November 1, 2020 10:59

mvnetbiz commented Nov 1, 2020

View reviewed changes

pkgs/os-specific/linux/anbox/default.nix Outdated Show resolved Hide resolved

mvnetbiz changed the title ~~Anbox linux~~ pkgs.anbox: unstable-2019-11-15 -> unstable-2020-10-26, nixos/anbox: use mainline drivers when available Nov 1, 2020

mvnetbiz requested review from Mic92, gebner and worldofpeace November 1, 2020 12:22

mvnetbiz force-pushed the anbox-linux branch from ce9adfc to d8b4923 Compare November 3, 2020 05:25

mvnetbiz marked this pull request as ready for review November 3, 2020 05:27

mvnetbiz added the 2.status: work-in-progress label Nov 6, 2020

mvnetbiz force-pushed the anbox-linux branch from d8b4923 to 173259a Compare November 19, 2020 06:07

spinus reviewed Nov 28, 2020

View reviewed changes

Atemu mentioned this pull request Dec 23, 2020

linuxPackages_latest.anbox fails to build (kallsyms_lookup_name) #91367

Open

Atemu approved these changes Dec 23, 2020

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 7, 2021

mvnetbiz force-pushed the anbox-linux branch from 173259a to 1aaed06 Compare January 7, 2021 04:38

mvnetbiz requested review from edolstra, jonringer, peti, roberth and ttuegel as code owners January 7, 2021 04:38

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 28, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

868ec39

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 29, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

a9c21e0

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

github-actions bot pushed a commit that referenced this pull request Dec 3, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

c1968ed

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from #102341 (cherry picked from commit c2e142d)

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Dec 7, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

3884c2a

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Dec 12, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

6a267a5

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Dec 24, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

9418611

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Dec 25, 2021

linux: CONFIG_ASHMEM=y, CONFIG_ANDROID=y

9e9d04a

This enables ashmem, binder so waydroid/anbox works with the provided linux kernel Cherry-picked from NixOS#102341

VergeDX approved these changes Jan 23, 2022

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 31, 2022

mvnetbiz closed this Apr 7, 2023

Uh oh!

Conversation

mvnetbiz commented Nov 1, 2020

Motivation for this change

Things done

Uh oh!

Uh oh!

mvnetbiz commented Nov 3, 2020

Uh oh!

mvnetbiz commented Nov 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spinus commented Nov 28, 2020

Uh oh!

mvnetbiz commented Dec 3, 2020

Uh oh!

Atemu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bqv commented Jan 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants