Skip to content

CastXML: refactor to avoid python2 dependency#101996

Merged
teto merged 1 commit intoNixOS:masterfrom
braunse:update-castxml-python2-dep
Oct 29, 2020
Merged

CastXML: refactor to avoid python2 dependency#101996
teto merged 1 commit intoNixOS:masterfrom
braunse:update-castxml-python2-dep

Conversation

@braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020

Switch pythonPackages.sphinx to python3Packages.sphinx. Should
only affect the build of the man-page.

Motivation for this change

Removing python2 deps: #101964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@braunse
CastXML: refactor to avoid python2 dependency
a86b342 
Switch pythonPackages.sphinx to python3Packages.sphinx. Should
only affect the build of the man-page.
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 29, 2020
@teto
Copy link
Member

teto commented Oct 29, 2020

5 packages built:
castxml python27Packages.pybindgen python27Packages.pygccxml python37Packages.pygccxml python38Packages.pygccxml

@teto teto merged commit a74a5c9 into NixOS:master Oct 29, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101996 run on x86_64-darwin 1

5 packages built:
  • castxml
  • python27Packages.pybindgen
  • python27Packages.pygccxml
  • python37Packages.pygccxml
  • python38Packages.pygccxml

@braunse braunse deleted the update-castxml-python2-dep branch October 30, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@braunse @teto @SuperSandro2000