libretro.mame2016: fix build with Make 4.3#101949
Merged
hrdinka merged 1 commit intoNixOS:masterfrom Oct 29, 2020
Merged
Conversation
SuperSandro2000
requested changes
Oct 28, 2020
Builds currently fail with `ar` trying to operate on what are clearly two paths concatenated together. It stems from a backward-incompatible change in Make: > Previously appending using '+=' to an empty variable would result in > a value starting with a space. Now the initial space is only added > if the variable already contains some value. Similarly, appending an > empty string does not add a trailing space. This issue was first reported on the MAME repository proper (mamedev/mame#6248), and affects libretro's 2016 snapshot as well. A fix that is reported to work with previous versions of Make was upstreamed to: - GENie, the build system: bkaradzic/GENie#493 - MAME: mamedev/mame#6262 - libretro: libretro/mame2016-libretro#47 The fetched patch comes from the last of these.
5d1261d to
8880179
Compare
Member
|
Result of @GrahamcOfBorg Where is the one darwin package? |
Contributor
|
Thanks a lot for the fix 👍 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Builds currently fail with
artrying to operate on what are clearly two paths concatenated together. It stems from a backward-incompatible change in Make:This issue was first reported on mamedev/mame#6248, and affects libretro's 2016 snapshot as well. A fix that is reported to work with previous versions of Make was upstreamed to GENie, the build system, MAME, and now to libretro-mame2016 (pending), from which the patch comes.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)If this gets backported to 20.09,
libretrocan then be unmarked as broken, as far as I can tell.