Skip to content

go_bootstrap: disable failing timezone tests#101843

Merged
zowoq merged 1 commit intoNixOS:staging-nextfrom
zowoq:goboot
Oct 27, 2020
Merged

go_bootstrap: disable failing timezone tests#101843
zowoq merged 1 commit intoNixOS:staging-nextfrom
zowoq:goboot

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 27, 2020

Motivation for this change

Fixes https://hydra.nixos.org/build/129275183/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested review from Mic92 and kalbasit as code owners October 27, 2020 11:55
@ofborg ofborg bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Oct 27, 2020
@ofborg ofborg bot requested a review from cstrahan October 27, 2020 12:06
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 27, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Oct 27, 2020

@ofborg build go_1_14 go_1_15

@zowoq
Copy link
Contributor Author

zowoq commented Oct 27, 2020

cc @FRidh @vcunat

staging-next looks like it's fine now but I don't want to merge this just in case it isn't.

vcunat
vcunat approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for staging-next, I believe. It seems to succeed on master, perhaps the tzdata update was exactly in master..staging-next. Diff/approach looks OK to me at a quick glance, too.

@zowoq zowoq merged commit 8c9bb91 into NixOS:staging-next Oct 27, 2020
@zowoq zowoq deleted the goboot branch October 27, 2020 14:37
@flokli flokli mentioned this pull request Oct 28, 2020
Merged
10 tasks
@flokli flokli mentioned this pull request Nov 5, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees

No one assigned

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zowoq @vcunat