haskellPackages.trifecta: dontCheck on darwin#101602
Merged
zowoq merged 1 commit intoNixOS:masterfrom Oct 25, 2020
zowoq:trifecta
Merged
haskellPackages.trifecta: dontCheck on darwin#101602zowoq merged 1 commit intoNixOS:masterfrom zowoq:trifecta
zowoq merged 1 commit intoNixOS:masterfrom
zowoq:trifecta
Conversation
cdepillabout
approved these changes
Oct 25, 2020
Member
cdepillabout
left a comment
There was a problem hiding this comment.
Normally we like to send PRs touching pkgs/development/haskell-modules/configuration-common.nix to the haskell-updates branch, but since you need this to unbreak master, let's just merge it in to master.
Feel free to merge after ofborg finishes (or before if you've tested it locally and know it should be working).
cc @peti
Member
|
To be clear, Ofborg builds for darwin won't work, as it's had no darwin builders for weeks. |
Contributor
Author
|
Whoops, I missed the notification that it was approved. I've tested pandoc and shellcheck locally. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hydra.nixos.org/build/129070963/nixlog/1
This unblocks
nixpkgs-unstablewhile we're trying to get thecctoolsproblems resolved.#101442
#101441
#101330
Built shellcheck (and pandoc) on darwin.
cc @vcunat