ruby: fix build on darwin#101441
Conversation
cc-tools 949.0.1 added a warning on linking which ruby misinterprets as an error with LDFLAGS.
|
Hmm, I still have the same issue with this. Fails at |
|
that is weird, I can build it on darwin: $ nix-build -A ruby
/nix/store/rvb7avdslzv8rc60cgj13pzkqyr0a8bx-ruby-2.6.6did you use nixpkgs-review? could you please create a pastebin with the output? |
|
I'm also still getting the same error with this PR. The output is the same as https://hydra.nixos.org/build/128219205/nixlog/2 except for the patch being applied: |
|
Would you mind checking whether it works with the following patch? diff -Naur ruby.old/tool/darwin-cc ruby.new/tool/darwin-cc
--- ruby.old/tool/darwin-cc
+++ ruby.new/tool/darwin-cc
@@ -2,5 +2,6 @@
exec 2> >(exec grep -v \
-e '^ld: warning: The [a-z0-9_][a-z0-9_]* architecture is deprecated for macOS' \
-e '^ld: warning: text-based stub file /System/Library/Frameworks/' \
+ -e '^ld: warning: passed two min versions' \
>&2)
exec "$@"if it doesn't work, I think we can apply #101330 (comment) |
Same error unfortunately. |
|
@marsam Does not work with the original PR or your change. #101330 (comment) works for me. |
|
I opted to use @r-burns solution with |
|
Sounds good to me. I imagine we'll just revert this and #101602 once the underlying issue is fixed. |
Motivation for this change
cc-tools 949.0.1 added a warning on linking which ruby misinterprets as
an error with LDFLAGS.
fixes #101330
cc: @r-burns
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)