Skip to content

Comments

Fix kdeconnect#101272

Merged
edolstra merged 2 commits intoNixOS:masterfrom
edolstra:fix-kdeconnect
Oct 22, 2020
Merged

Fix kdeconnect#101272
edolstra merged 2 commits intoNixOS:masterfrom
edolstra:fix-kdeconnect

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 21, 2020

Motivation for this change

Fixes #99951. Also bumps kdeconnect to 20.08.2 to fix an incorrect MIME type.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edolstra
kdeconnect: Use Qt 5.12
fa08ce0 
Fixes NixOS#99951.

  $ kdeconnect-app
  Cannot mix incompatible Qt library (5.12.7) with this library (5.15.0)
  Aborted (core dumped)
@edolstra
kdeconnect: 20.08.1 -> 20.08.2
42bf618 
Fixes an invalid MIME type.
@edolstra edolstra added 9.needs: port to stable A PR needs a backport to the stable release. 6.topic: qt/kde Object-oriented framework for GUI creation labels Oct 21, 2020
@ofborg ofborg bot removed the 6.topic: qt/kde Object-oriented framework for GUI creation label Oct 21, 2020
@doronbehar
Copy link
Contributor

doronbehar commented Oct 21, 2020

Makes sense to me, but I'd be surprised if it'd help, considering #100707. Maybe use libsForQt514.callPackage until #100707 is fixed?

@ofborg ofborg bot requested a review from FRidh October 21, 2020 19:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2020
@edolstra
Copy link
Member Author

edolstra commented Oct 21, 2020

It fixes kdeconnect for me. I don't know if it's the best fix though.

I just tried libsForQt514. It doesn't work either:

$ ./result/bin/kdeconnect-app 
Cannot mix incompatible Qt library (version 0x50c07) with this library (version 0x50e02)
Aborted (core dumped)

@edolstra edolstra merged commit 357a62d into NixOS:master Oct 22, 2020
@edolstra edolstra deleted the fix-kdeconnect branch October 22, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kdeconnect is broken in 20.09

2 participants

@edolstra @doronbehar