Skip to content

[WIP] sage: 8.9 -> 9.1#101116

Closed
omasanori wants to merge 1 commit intoNixOS:masterfrom
omasanori:sage-9.1
Closed

[WIP] sage: 8.9 -> 9.1#101116
omasanori wants to merge 1 commit intoNixOS:masterfrom
omasanori:sage-9.1

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 20, 2020

Motivation for this change

THIS DOES NOT WORK YET

This change updates sage to a newer version. Migrating to Python 3 is out of scope for this moment.

Currently, it fails to build sagelib with the following error:

g++ -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/build/cythonized/sage/libs/linbox/linbox_flint_interface.o -L/nix/store/a9w45db5c2gyjv3zhdvarm7rw8s6a3jl-linbox-1.6.3/lib -L/nix/store/f48376wgp8cy00sxglmk79dv0ga5xvid-givaro-4.1.1/lib -L/build/sage-src-9.1/lib -L/nix/store/a3zwdl2m606mynzxcqa77ymk6a3j9nnf-python-2.7.18/lib -llinbox -lgivaro -lflint -lgmp -lgmpxx -lcblas -lstdc++ -lpython2.7 -o build/lib.linux-x86_64-2.7/sage/libs/linbox/linbox_flint_interface.so @LINBOXSAGE_LIBS@ -fopenmp
g++: error: LINBOXSAGE_LIBS@: No such file or directory

which indicates that variable substitution is incomplete for some reasons.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori
sage: 8.9 -> 9.1
9068036 
Some changes are derived from NixOS#70474
originally published by Timo Kaufmann.

Signed-off-by: Masanori Ogino <[email protected]>
@omasanori omasanori mentioned this pull request Oct 20, 2020
Closed
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 20, 2020
@omasanori
Copy link
Contributor Author

omasanori commented Oct 21, 2020

Following the maintainer's suggestion, the current target is to-be-released-soon SageMath 9.2 instead of 9.1. SageMath 9.2 removes sagenb, a component causing many adhoc workarounds in the package, and supports Python 3 only.

@omasanori
Copy link
Contributor Author

omasanori commented Oct 22, 2020

Superseded by the to-be-pull-requested https://github.com/omasanori/nixpkgs/tree/sage-9.2 branch.

@omasanori omasanori closed this Oct 22, 2020
@omasanori omasanori deleted the sage-9.1 branch October 22, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@omasanori