Skip to content

texlive: 2019 -> 2020#100121

Merged
veprbl merged 6 commits intoNixOS:masterfrom
veprbl:pr/texlive_2020
Oct 11, 2020
Merged

texlive: 2019 -> 2020#100121
veprbl merged 6 commits intoNixOS:masterfrom
veprbl:pr/texlive_2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Oct 10, 2020 •
edited
Loading

Motivation for this change

Provide minor fixes for some items in texlive.bin. Update to the latest texlive snapshot.
Closes: #91994

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
nix path-info -h -S /nix/store/vb3l4zhkigrniqh400vl96qly8kpbhd1-texlive-combined-full-2020 -S /nix/store/0rlzarjqrplckcfdydk22na48dfj7zk9-texlive-combined-full-2019
/nix/store/0rlzarjqrplckcfdydk22na48dfj7zk9-texlive-combined-full-2019     3.4G
/nix/store/vb3l4zhkigrniqh400vl96qly8kpbhd1-texlive-combined-full-2020     3.8G

@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 10, 2020
@gebner
Copy link
Member

gebner commented Oct 10, 2020

Builds and works for me (tested on a few latex files).

@gebner
Copy link
Member

gebner commented Oct 11, 2020

This PR is still marked as draft, but pretty much LGTM from my side. Is there anything that you still want to do?

veprbl added 5 commits October 11, 2020 12:28
@veprbl
texlive.bin.core: avoid building lua{53,jit} libraries
69e0797
@veprbl
texlive.bin.mflua: init
b797fb2
@veprbl
texlive.combined.scheme-infraonly: enable building on Hydra
1e87de1 
This used to be broken, but recently was fixed.
@veprbl
texlive.bin: provide luajittex and mfluajit binaries
d2a3ac3 
The ppc64 condition is based on previous reports and was not tested on
actual hardware.
@veprbl
texlive: 2019 -> 2020
10438ba 
Also change default package version from texlive year to a
revision. The problem with using texlive year is that it will change
on each of our update even if the package itself was not updated. The
texlive SVN revision number should not change unless the package is
updated. This will allow to share more store paths between different
texlive versions.
@veprbl
Copy link
Member Author

veprbl commented Oct 11, 2020

@gebner Just pushed a new changeset. Main difference is a change of default versioning scheme for unversioned packages, it now uses SVN revision number instead of the texlive year. There are also minor tweaks for luajit (cc @CrystalGamma for ppc64 changes).

We usually had major texlive updates sit for a while before getting merged, but we could try merging sooner this time.

@veprbl veprbl marked this pull request as ready for review October 11, 2020 16:41
@veprbl
Copy link
Member Author

veprbl commented Oct 11, 2020

@GrahamcOfBorg build tests.texlive texlive.combined.scheme-full

@gebner
Copy link
Member

gebner commented Oct 11, 2020

We usually had major texlive updates sit for a while before getting merged, but we could try merging sooner this time.

I know, in 2017 I merged the texlive update after it had been sitting around for over a month with no activity, and we only got bug reports after it was merged.

We don't gain much by letting this PR sit longer than necessary. If it builds, then I think we should merge it.

@veprbl veprbl merged commit 2cdd6d1 into NixOS:master Oct 11, 2020
@veprbl veprbl mentioned this pull request Oct 12, 2020
Closed
@gebner
Copy link
Member

gebner commented Oct 13, 2020

I ran into one regression, the new biber 2.15 doesn't like authors such as Jean{-}Marc. This is already fixed upstream (but not released yet): plk/biber#329

@veprbl veprbl mentioned this pull request Oct 13, 2020
Merged
10 tasks
dtzWill
dtzWill reviewed Oct 17, 2020
View reviewed changes
pkgs/tools/typesetting/tex/texlive/bin.nix
})
];

# remove when removing synctex-missing-header.patch
Copy link
Member

@dtzWill dtzWill Oct 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should've been removed before, per:comment?

Copy link
Member Author

@veprbl veprbl Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtzWill Nice catch, this should have been addressed back in update to 2019. Opened #101016. Thanks!

@veprbl veprbl deleted the pr/texlive_2020 branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dtzWill dtzWill dtzWill left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: TeX Issues regarding texlive and TeX in general 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TeXLive 2020 update

3 participants

@veprbl @gebner @dtzWill