qt5.qtwebengine: Sessions restore patch#100041
Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
Closed
qt5.qtwebengine: Sessions restore patch#100041doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar wants to merge 1 commit intoNixOS:masterfrom
Conversation
doronbehar
added
the
1.severity: security
10 tasks
ofborg
bot
added
10.rebuild-darwin: 11-100
doronbehar
force-pushed
the
pkg/qt/webengine-patch
branch
from
13506ca to
2547b3d
Compare
doronbehar
force-pushed
the
pkg/qt/webengine-patch
branch
from
2547b3d to
6ef704c
Compare
Contributor
Author
|
Targeting PR to |
Contributor
|
Note this isn't a security patch - it patches crashes happening with Qt 5.15.1 which make it almost unusable otherwise, but they are not security related. What I meant in #99456 (comment) is that it's a bad idea for the qutebrowser package to depend on Qt 5.14 instead of 5.15. |
Contributor
Author
Now I notice our qt5.15 is qt5.15.0 but the patch applies to it as well. It's still good to apply it right? |
Contributor
Author
|
Fixed the commit message. |
doronbehar
force-pushed
the
pkg/qt/webengine-patch
branch
from
6ef704c to
b206142
Compare
Contributor
Surely doesn't hurt. I don't know which change between Qt 5.15.0 and .1 triggered the issue. |
doronbehar
changed the title
doronbehar
removed
the
1.severity: security
Contributor
Author
|
Closed in favor of #102216 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #99456 (comment)
cc @ttuegel .
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)