Skip to content

ghcjs tests not running because the compiler version check is nonsensical #61710

@nh2

Description

@nh2

We noticed that ghcjs packages always run with --disable-tests.

This is most likely accidental, because we have in the generic Haskell builder:

(optionalString (isGhcjs || versionOlder "7" ghc.version) (enableFeature doCheck "tests"))

, doCheck ? !isCross && (stdenv.lib.versionOlder "7.4" ghc.version)

For ghcjs, ghc.version is 0.2.020170323.

So the tests don't run because 0.2.020170323 < 7.4.

The problem here is that ghcjs uses a different versioning scheme from ghc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: haskellGeneral-purpose, statically typed, purely functional programming language

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions