-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Closed
Closed
Copy link
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: haskellGeneral-purpose, statically typed, purely functional programming languageGeneral-purpose, statically typed, purely functional programming language
Description
We noticed that ghcjs packages always run with --disable-tests.
This is most likely accidental, because we have in the generic Haskell builder:
| (optionalString (isGhcjs || versionOlder "7" ghc.version) (enableFeature doCheck "tests")) |
| , doCheck ? !isCross && (stdenv.lib.versionOlder "7.4" ghc.version) |
For ghcjs, ghc.version is 0.2.020170323.
So the tests don't run because 0.2.020170323 < 7.4.
The problem here is that ghcjs uses a different versioning scheme from ghc.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: haskellGeneral-purpose, statically typed, purely functional programming languageGeneral-purpose, statically typed, purely functional programming language