-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Closed
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules
Description
Issue description
While the system we have right now is good for contributing, I think each new nix expression should have a test in nixos/tests written along with it in each new PR.
We should do this retroactively where possible for all currently existing packages too.
This way, we can ensure everything works with hydra, and be alerted quickly for broken, but successfully built expressions that may not be actively maintained and (user) tested anymore.
Would it be possible to change the policy in Contributing to do this?
The flow I see is this:
- Make new expression for program X
- Test locally to ensure it works
- Make test in nixos/tests for it so hydra can do this automatically
- Submit PR after everything fits Contributing.
Is this a good idea, something we should implement? I see more benefits that drawbacks.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules