-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Open
Labels
5.scope: trackingLong-lived issue tracking long-term fixes or multiple sub-problemsLong-lived issue tracking long-term fixes or multiple sub-problems
Description
Tracking description
Remove with lib from meta sections is a common nitpick that comes into reviews. with is a useful feature but it's overuse can often some silent eval issues that otherwise would be mostly caught with static analysis.
While experimenting with removing it treewide retroactively, I created #371665 which is too big to merged in one go so this issue was created to track the dismembering of that big PR into smaller human reviewable PRs.
The whole effort can be separated in the following stages:
- Add a CI workflow to find common issues around this. NPV-169: detect too-broad
withexpressions; ratchet them down nixpkgs-vet#142 - Retroactively migrate the whole repository in small increments using the chungus PR as a starting point.
Reference Issue(s)/PR(s)
- ...
Follow-up issues/notes
Additional context
Add any other context about the problem here.
Add a 👍 reaction to issues you find important.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
5.scope: trackingLong-lived issue tracking long-term fixes or multiple sub-problemsLong-lived issue tracking long-term fixes or multiple sub-problems