-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Open
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: best practicesDocumentation and discussion around best practices for Nixpkgs developmentDocumentation and discussion around best practices for Nixpkgs development6.topic: developer experiencenixpkgs development workflownixpkgs development workflow9.needs: community feedbackThis needs feedback from more community members.This needs feedback from more community members.9.needs: documentationThis needs to be documented well.This needs to be documented well.
Description
In #346858 we identified the need for clearer commit guidelines on the degree of commit separation for PRs. Let's use this issue to discuss it.
Currently we have these two pieces in our commit conventions:
Create a commit for each logical unit.
If you have commits
pkg-name: oh, forgot to insert whitespace: squash commits in this case. Usegit rebase -i.
Ping @GetPsyched @fpletz @vifino
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: best practicesDocumentation and discussion around best practices for Nixpkgs developmentDocumentation and discussion around best practices for Nixpkgs development6.topic: developer experiencenixpkgs development workflownixpkgs development workflow9.needs: community feedbackThis needs feedback from more community members.This needs feedback from more community members.9.needs: documentationThis needs to be documented well.This needs to be documented well.