Skip to content

Improve guidelines on commit separation #347586

@infinisil

Description

@infinisil

In #346858 we identified the need for clearer commit guidelines on the degree of commit separation for PRs. Let's use this issue to discuss it.

Currently we have these two pieces in our commit conventions:

Create a commit for each logical unit.

If you have commits pkg-name: oh, forgot to insert whitespace: squash commits in this case. Use git rebase -i.

Ping @GetPsyched @fpletz @vifino

Metadata

Metadata

Assignees

No one assigned

    Labels

    2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: best practicesDocumentation and discussion around best practices for Nixpkgs development6.topic: developer experiencenixpkgs development workflow9.needs: community feedbackThis needs feedback from more community members.9.needs: documentationThis needs to be documented well.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions