-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Open
Labels
1.severity: significantNovel ideas, large API changes, notable refactorings, issues with RFC potential, etc.Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs
Description
I recently wrote a tool that automatically performs a migration to the finalAttrs pattern (#119942), and I believe it is now robust enough to be let loose on nixpkgs.
However this is the first large treewide change I'm performing, so I'm not 100% sure how to proceed. Some questions:
- Is this desirable at all?
- Should I perform the migration in steps or all at once?
- One big commit or one commit per package?
- Do we review all changes or only a sample?
- @infinisil you are working on the by-name migration (RFC 140 migration plan #258650). Do you think this could interfere? Should I wait until your migration is complete?
cc @drupol who was interested in this
Example run of the tool on pkgs/applications and pkgs/by-name: https://github.com/fgaz/nixpkgs/commits/finalattrs-test-8/
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
1.severity: significantNovel ideas, large API changes, notable refactorings, issues with RFC potential, etc.Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs