-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Bazel 7 PATH issues #289505
Copy link
Copy link
Open
Labels
0.kind: questionRequests for a specific question to be answeredRequests for a specific question to be answered2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: best practicesDocumentation and discussion around best practices for Nixpkgs developmentDocumentation and discussion around best practices for Nixpkgs development
Metadata
Metadata
Assignees
Labels
0.kind: questionRequests for a specific question to be answeredRequests for a specific question to be answered2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: best practicesDocumentation and discussion around best practices for Nixpkgs developmentDocumentation and discussion around best practices for Nixpkgs development
Fields
Give feedbackNo fields configured for issues without a type.
This issue is here to discuss issues with PATH when using bazel 7 as packaged in nix.
When packaging bazel_7, I removed the (
action_pathpatch)[https://github.com/NixOS/nixpkgs/blob/1012b2a368b12c3c5751b06123214de202e28778/pkgs/development/tools/build-managers/bazel/bazel_6/actions_path.patch] from bazel_6, because it did not make sense to have it.But removing that patch has consequences. Some actions now run with no PATH at all. What I am unable to figure right now is how to fix that.
It would be nice to setup a MWE to test it on several machines.
AFAIU the issue arises when you run a binary process (that needs no PATH set to run) but that binary ends up running system commands (using
system()or calling a bash script) which then fails to find it's dependencies.As mentioned in some places, we may want to tweak that path without having to recompile bazel.
See
#262152
#285544
https://github.com/sourcegraph/sourcegraph/pull/59359
and possibly some more I have forgotten.
/cc @malt3 @uri-canva @Strum355 @flurie @boltzmannrain @rickvanprim as you might be interested in this discussion.