-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Closed
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.6.topic: pythonPython is a high-level, general-purpose programming language.Python is a high-level, general-purpose programming language.9.needs: community feedbackThis needs feedback from more community members.This needs feedback from more community members.
Description
Issue description
Most Python library expressions are in python-packages.nix and some are called using callPackage.
We applied makeOverridable to buildPythonPackage so we can override the Python packages. However, callPackage = pkgs.newScope self; also sets a override attribute which is applied later thus taking precedence. We should provide a common method for overriding Python libraries.
Possible methods I can think of:
- Define
callPackagewithout providing aoverrideattribute. Theoverrideattribute should now correspond to the one added tobuildPythonPackagebymakeOverridable. - Add a
buildPythonPackage.overridePythonPackagemethod.
I suppose the first would be easiest and the second the most robust.
It would by the way be nice if makeOverridable would allow you to set the attribute used for overriding.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.6.topic: pythonPython is a high-level, general-purpose programming language.Python is a high-level, general-purpose programming language.9.needs: community feedbackThis needs feedback from more community members.This needs feedback from more community members.