-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Open
Labels
0.kind: bugSomething is brokenSomething is broken0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: developer experiencenixpkgs development workflownixpkgs development workflow6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOSIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules
Description
Describe the bug
We have become accustomed to some tests failing every now and then.
Making sweeping changes is harder than necessary because we can't trust the outcomes of tests.
Flaky tests are a nuisance to everyone who invests good work to get changes through and have the side-effect of wearing down motivation to painstaking.
Steps To Reproduce
Steps to reproduce the behavior:
- Make a mass-rebuild change or a change to the test driver
- Some tests fail inexplicably. What now?
Expected behavior
Flaky tests can be marked as such, so that they can still be fixed and don't bog anyone down.
See also earlier short discussion:
Some requirements for the marking solution:
- hydra puts the flaky tests in a separate attrset for easy recognition
- marking / unmarking is a one-line change; no file moving churn
- evaluation does not suffer: no attribute set filtering, but rather
mapAttrsto set some tests to null (and only on Hydra) pkgs.nixosTestsattrset works the same regardless of flakiness statuspkgs.nixosTestsprints a warning when evaluation or running a known-flaky test- update the manual; change what was added in nixos/doc: Add Developing the Test Driver #216660
Additional context
Notify maintainers
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output hereReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
0.kind: bugSomething is brokenSomething is broken0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: developer experiencenixpkgs development workflownixpkgs development workflow6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOSIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules