Discourage/prohibit inheriting from package sets in callPackage #204303
Description
in all-packages.nix when something is inherited (ex, {inherit (pkgs.darwin.apple_sdk.frameworks) Security;}) in a callPackage invocation the inherited attr will not have __spliced and so won't be cross-compilation compatible.
one way to fix this would be to change the with pkgs; in all-packages to with pkgs.__splicedPackages like tried in #58327
however that will result in other issues like infinite recursion.
$ nix build ".#pkgsCross.aarch64-multiplatform.bash"
error: infinite recursion encountered
other way to work around it would be to to inherit from the __splicedPackages set (ex, {inherit (pkgs.__splicedPackages.darwin.apple_sdk.frameworks) Security;})
the way i prefer would be to just not inherit from package sets
Demo: show-splices.nix
let
pkgs = import ./. { };
pkgsCross = pkgs.pkgsCross.aarch64-multiplatform;
workingSplices = pkgsCross.callPackage
({ darwin, xorg }: {
d = darwin.apple_sdk.frameworks.Security.__spliced;
x = xorg.libX11.__spliced;
})
{ };
notWorkingSplices = pkgsCross.callPackage
({ Security, libX11 }: {
d = Security.__spliced;
x = libX11.__spliced;
})
{
inherit (pkgsCross.darwin.apple_sdk.frameworks) Security;
inherit (pkgsCross.xorg) libX11;
};
in
{
# for --json to work
workingSplices =
removeAttrs workingSplices [ "override" "overrideDerivation" ];
notWorkingSplices =
removeAttrs notWorkingSplices [ "override" "overrideDerivation" ];
}working:
$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix eval -f show-splices.nix workingSplices --json | jq
{
"d": {
"buildBuild": "/nix/store/ls83bixygn2bzqq1w2z66dyccfn61wic-apple-framework-Security",
"buildHost": "/nix/store/ls83bixygn2bzqq1w2z66dyccfn61wic-apple-framework-Security",
"buildTarget": "/nix/store/ls83bixygn2bzqq1w2z66dyccfn61wic-apple-framework-Security",
"hostHost": "/nix/store/vhqjns1zfab6cnv2lbkr6gff1fa8n3kw-apple-framework-Security-11.0.0",
"hostTarget": "/nix/store/vhqjns1zfab6cnv2lbkr6gff1fa8n3kw-apple-framework-Security-11.0.0"
},
"x": {
"buildBuild": "/nix/store/w3zzhfl4a7xp0xfflz2gawv02y8ba9z8-libX11-1.8.1",
"buildHost": "/nix/store/w3zzhfl4a7xp0xfflz2gawv02y8ba9z8-libX11-1.8.1",
"buildTarget": "/nix/store/w3zzhfl4a7xp0xfflz2gawv02y8ba9z8-libX11-1.8.1",
"hostHost": "/nix/store/gjh7n6myi7miwprjkk4lll8cp1j7kmz8-libX11-aarch64-unknown-linux-gnu-1.8.1",
"hostTarget": "/nix/store/gjh7n6myi7miwprjkk4lll8cp1j7kmz8-libX11-aarch64-unknown-linux-gnu-1.8.1"
}
}
broken:
}
$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix eval -f show-splices.nix notWorkingSplices --json | jq
error: attribute '__spliced' missing
at /home/artturin/nixgits/my-nixpkgs/show-splices.nix:5:74:
4| workingSplices = pkgsCross.callPackage ({ darwin, xorg }: { d = darwin.apple_sdk.frameworks.Security.__spliced; x = xorg.libX11.__spliced;}) { };
5| notWorkingSplices = pkgsCross.callPackage ({ Security, libX11 }: { d = Security.__spliced; x = libX11.__spliced;}) { inherit (pkgsCross.darwin.apple_sdk.frameworks) Security; inherit (pkgsCross.xorg) libX11; };
| ^
6| in
{
"d": null
}
related issues:
#49526