-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
Description
Currently, when doCheck is disabled globally for all python packages, many python packages fail to build.
The root cause seems to be that mk-python-derivation doesn't enforce runtime dependencies to be specified via propagatedBuildInputs. Instead, runtime deps are often specified inside checkInputs. If doCheck is disabled, then these deps will be missing.
My personal motivation for fixing that is to improve the usability of mach-nix, which currently fails in some cases due to missing dependencies.
My idea would be to modify the pip-install-hook, so that it doesn't see the checkInputs inside the PYTHONPATH during installation.
This in turn would force maintainers to properly specify all deps via propagatedBuildInputs.
The problem is that I cannot find the place, where checkInputs is added to the PYTHONPATH.
If you guys could give me a hint, or have any better ideas on how to solve that problem, I'd highly appreciate it.