bintools-wrapper change causes builds to fail on darwin - ld: Assertion failed #105573
Description
TLDR;
The builds error out with:
ld: Assertion failed: (targetAtom != NULL), function Fixup, file ../../../../ld64/src/ld/ld.hpp, line 776.
Currently effected packages are:
libmodplug(fixed with libmodplug: Fix build on darwin #106430)bazel(2021-02-02: fixed by using clang 7 to build, and removing the-mmacosx-version-minflag -- see bazel: 3.3.1 -> 3.7.2 #105439 (comment))- bazel-watcher (see bazel-watcher: 0.13.1 -> 0.14.0 #105669 (comment))
@uri-canva bisected this commit 473b341 to be responsible for the error, and verified that reverting that change makes them build again.
Seems like libmodplug broke in eval 1628634, when the changes for big sur where merged: #98541 (changes)
Could this be a reason for those linker errors?
Originally posted by @avdv in #105439 (comment)
For posterity:
load_pat.lo modplug.lo -lm
libtool: link: clang++ -dynamiclib -Wl,-undefined -Wl,dynamic_lookup -o .libs/libmodplug.1.dylib .libs/sndmix.o .libs/sndfile.o .libs/snd_fx.o .libs/snd_flt.o .libs/snd_dsp.o .libs/fastmix.o .libs/mmcmp.o .libs/load_xm.o .libs/load_wav.o .libs/load_umx.o .libs/load_ult.o .libs/load_stm.o .libs/load_s3m.o .libs/load_ptm.o .libs/load_okt.o .libs/load_mtm.o .libs/load_mod.o .libs/load_med.o .libs/load_mdl.o .libs/load_it.o .libs/load_far.o .libs/load_dsm.o .libs/load_dmf.o .libs/load_dbm.o .libs/load_ams.o .libs/load_amf.o .libs/load_669.o .libs/load_j2b.o .libs/load_mt2.o .libs/load_psm.o .libs/load_abc.o .libs/load_mid.o .libs/load_pat.o .libs/modplug.o -lm -g -O2 -mmacosx-version-min=10.5 -mmacosx-version-min=10.5 -install_name /nix/store/v8hkzrplvwcikdidk761a04by98wjs3j-libmodplug-0.8.9.0/lib/libmodplug.1.dylib -compatibility_version 2 -current_version 2.0 -Wl,-single_module
0 0x10ff56a51 __assert_rtn + 129
1 0x11012f444 ld::passes::stubs::x86_64::classic::LazyPointerAtom::LazyPointerAtom(ld::passes::stubs::Pass&, ld::Atom const&, bool, bool) + 420
2 0x11012cc6a ld::passes::stubs::Pass::makeStub(ld::Atom const&, bool) + 2762
3 0x11012dc5f ld::passes::stubs::Pass::process(ld::Internal&) + 2511
4 0x11012e2c0 ld::passes::stubs::doPass(Options const&, ld::Internal&) + 128
5 0x10ff57ff4 main + 1860
A linker snapshot was created at:
/tmp/libmodplug.1.dylib-2020-10-22-030016.ld-snapshot
ld: Assertion failed: (targetAtom != NULL), function Fixup, file ../../../../ld64/src/ld/ld.hpp, line 776.
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:492: libmodplug.la] Error 1
Seems to happen with clang 6 and clang 7.