Skip to content

raspberry-pi/5: init#927

Merged
mergify[bot] merged 7 commits intoNixOS:masterfrom
leo60228:raspberry-pi-5
May 6, 2024
Merged

raspberry-pi/5: init#927
mergify[bot] merged 7 commits intoNixOS:masterfrom
leo60228:raspberry-pi-5

Conversation

@leo60228
Copy link
Member

@leo60228 leo60228 commented Apr 30, 2024

Description of changes

Add necessary configuration for the Raspberry Pi 5. More detailed documentation is on the wiki.

Supersedes NixOS/nixpkgs#284391.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@leo60228 leo60228 mentioned this pull request Apr 30, 2024
Closed
13 tasks
nvmd
nvmd reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@nvmd nvmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I'm also working on bringing at least some level of support to RPi5 until upstream support is there, we definitely need to start somewhere with moving/adding 5's support to nixos-hardware.

@leo60228 @nvmd
raspberry-pi/5: add nvme module
c649cd3 
Co-authored-by: Sergey Kazenyuk <[email protected]>
malteneuss
malteneuss reviewed May 1, 2024
View reviewed changes
malteneuss
malteneuss reviewed May 1, 2024
View reviewed changes
malteneuss
malteneuss reviewed May 1, 2024
View reviewed changes
@malteneuss malteneuss mentioned this pull request May 1, 2024
Open
@malteneuss
Copy link
Contributor

malteneuss commented May 1, 2024

@nvmd Do you have rights to merge?

@nvmd
Copy link
Member

nvmd commented May 1, 2024 •
edited
Loading

No, I don't, even if I had I would ask for a feedback more active members as well, whether this PR "fits" in its current state.
It will technically work, but considering the "push" from nixpkgs, maybe a more general approach for "pulling" this vendor's support to nixos-hardware should be taken.
E.g. the dependence on the nixpkgs for a vendor kernel doesn't look ideal, this is where better decoupling could be achieved.

Mic92
Mic92 reviewed May 5, 2024
View reviewed changes
@Mic92
Copy link
Member

Mic92 commented May 6, 2024

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 6, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 8a4adfe

@mergify mergify bot merged commit 8a4adfe into NixOS:master May 6, 2024
@malteneuss malteneuss mentioned this pull request May 8, 2024
Closed
This was referenced Aug 28, 2024
Closed
Closed
@tobiasBora
Copy link

tobiasBora commented Aug 31, 2024

To make this clear, is this supposed to be the official kernel for rpi5, or a slight modification of kernel 4 as suggested in the wiki?

@Ma27 Ma27 mentioned this pull request Jul 11, 2025
Merged
13 tasks
@danwdart
Copy link

danwdart commented Sep 18, 2025

& how might one build an image like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

+2 more reviewers

@nvmd nvmd nvmd left review comments

@malteneuss malteneuss malteneuss left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@leo60228 @malteneuss @nvmd @Mic92 @tobiasBora @danwdart