Skip to content

Fix Hetzner plugin#45

Merged
AmineChikhaoui merged 7 commits intoNixOS:masterfrom
tewfik-ghariani:hetzner-plugin
Jun 8, 2021
Merged

Fix Hetzner plugin#45
AmineChikhaoui merged 7 commits intoNixOS:masterfrom
tewfik-ghariani:hetzner-plugin

Conversation

@tewfik-ghariani
Copy link
Contributor

@tewfik-ghariani tewfik-ghariani commented May 23, 2021

Bringing the hetzner plugin up-to-date by addressing the following :

  • Poetry2nix dependency management
  • Use of machineOptions & removal of xml parsing
  • Black & mypy & github ci
  • Re-structuring & clean-up
  • Creation of a new utils file for now since some methods were changed in nixops core : NixOS/nixops@362d049

cc @AmineChikhaoui

@tewfik-ghariani tewfik-ghariani marked this pull request as ready for review May 26, 2021 19:47
@tewfik-ghariani tewfik-ghariani marked this pull request as draft May 27, 2021 22:26
@tewfik-ghariani tewfik-ghariani marked this pull request as ready for review May 28, 2021 02:04
@AmineChikhaoui
Copy link
Member

Thanks @tewfik-ghariani . We tested this on real infra and it seemed to work fine, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants