Switch from fixMergeModules to evalModules#1506
Merged
roberth merged 2 commits intoNixOS:masterfrom Feb 21, 2022
Merged
Conversation
Member
|
For the purpose of bisectability, could you split this into
|
fixMergeModules is deprecated and using it produces deprecation warning messages in newer revisions of nixpkgs. Since it's implemented as a simple wrapper around evalModules, let's just use evalModules instead and set the module arguments through config._module.args.
Contributor
Author
|
Done! |
roberth
approved these changes
Feb 21, 2022
Member
|
Thank you! |
9 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixMergeModulesis deprecated and using it produces deprecation warning messages in newer revisions of nixpkgs. Since it's implemented as a simple wrapper aroundevalModules, let's just useevalModulesinstead and set the module arguments throughconfig._module.args.Fixes #1507