Don't move trailing comments in let anymore#270
Merged
dasJ merged 1 commit intoNixOS:masterfrom Jan 7, 2025
Merged
Conversation
While this was initially introduced for good reasons, as can also be seen in the diff, that code was written with documentation comments in mind and not code comments. As per the bug report, the downsides were deemed to high to keep it in Fixes NixOS#259
dasJ
approved these changes
Jan 7, 2025
Member
dasJ
left a comment
dasJ
left a comment
There was a problem hiding this comment.
Result looks good, cannot judge the code though
infinisil
approved these changes
Jan 7, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #269 to delay it until after the Nixpkgs treewide
While this was initially introduced for good reasons, as can also be seen in the diff, that code was written with documentation comments in mind and not code comments. As per the bug report, the downsides were deemed to high to keep it in
Fixes #259