Conversation
Oh um, but then we need to redo NixOS/nixpkgs#359904, wait for another Hydra rebuild, then redo NixOS/nixpkgs#361165 |
As much as everyone would wish for, tabs are not whitespace according to Nix whitespace stripping. Fixes NixOS#116, but my overall confidence level in Nixfmt's correctness in parsing the mess which is the Nix syntax remains rather low.
piegamesde
force-pushed
the
final-polish
branch
from
d58725d to
4200d2e
Compare
|
Unfortunately, I stumbled upon #116 which I'd now consider a critical correctness issue and therefore blocking. I recently did a Nixpkgs treewide on fucked up strings (for a different variant of indented string syntax fuckup) and therefore know that such things actually still exist in the wild. |
Identifiers already were, that the others weren't was a mere oversight. Fixes NixOS#203
|
As for "Don't move trailing comments in let anymore", my suggestion would be to keep the commit out and thus the old behavior for the initial formatting, and then add it back in. The other commits are strongly recommended to include for the treewide |
piegamesde
force-pushed
the
final-polish
branch
from
124eca6 to
622ea8c
Compare
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Checked the diff, looking good to me, thanks! The third commit some people might not like due to it introducing more lines, but I think it's the right move to fix the reported problem (#198).
Final polish: NixOS/nixfmt#269 (cherry picked from commit cb3de35)
…361894) nixfmt-rfc-style: 2024-11-26 -> 2024-12-04 Final polish: NixOS/nixfmt#269 (cherry picked from commit cb3de35) Co-authored-by: Silvan Mosberger <[email protected]>
3 participants
Picking some low hanging fixes before the big treewide