Don't expand final list arguments of functions#254
Closed
Conversation
Will be useful in the next commit
Applies 331e0aa to last arguments too
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
infinisil
force-pushed
the
last-list-args
branch
from
7c1b26b to
228f526
Compare
Member
|
This produces a couple of weird outputs, like (mkRenamedOptionModule [
"services"
"xserver"
"displayManager"
"sddm"
"enable"
] [ "services" "displayManager" "sddm" "enable" ])Not sure how to easily solve that though Edit: okay so it turns out the solution is to stop caring about |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
9 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
Author
|
Superseded by #257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies #233 to last arguments too
Best review commit by commit
This work is sponsored by Antithesis ✨